Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add API types for DiscoverVariables hook #7986

Merged
merged 1 commit into from
Jan 27, 2023
Merged

🌱 Add API types for DiscoverVariables hook #7986

merged 1 commit into from
Jan 27, 2023

Conversation

killianmuldoon
Copy link
Contributor

Add the API types proposed for the DiscoverVariables extension to the runtime API package.

Part of #7985

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jan 24, 2023
Closed
34 tasks
@killianmuldoon killianmuldoon changed the title 🌱 Add API types for DiscoverVariables hook 🌱 [WIP] Add API types for DiscoverVariables hook Jan 24, 2023
killianmuldoon
killianmuldoon commented Jan 24, 2023
View reviewed changes
exp/runtime/hooks/api/v1alpha1/topologymutation_types.go
@@ -22,6 +22,7 @@ import (
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/types"

clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding this import is a problem here - we import the same for lifecycle hooks. But I did want to point it out to find out if there's any opinions about defining the variables for VariableDiscovery as their own type - in case changes need to be made down the line etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for bringing it up, I think same as for lifecycle hooks it's fine to have this dependency for now. Means we have to evolve them together but that should be okay for now.

killianmuldoon
killianmuldoon commented Jan 24, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jan 24, 2023
ykakarap
ykakarap reviewed Jan 25, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

exp/runtime/hooks/api/v1alpha1/topologymutation_types.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon changed the title 🌱 [WIP] Add API types for DiscoverVariables hook 🌱 Add API types for DiscoverVariables hook Jan 27, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0beb08a0baa56950313e514d6b6567ffa471da0a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 14ffcb2 into kubernetes-sigs:main Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@ykakarap ykakarap ykakarap left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @sbueringer @k8s-ci-robot @ykakarap