-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add discoverVariables runtime hook to ClusterClass reconcile loop #8006
✨ Add discoverVariables runtime hook to ClusterClass reconcile loop #8006
Conversation
c9bc8c1
to
f74f5d7
Compare
f74f5d7
to
1307b2e
Compare
1307b2e
to
f8f6213
Compare
/retest |
1c6094b
to
151a4d8
Compare
151a4d8
to
4a98ac7
Compare
@sbueringer this is ready for review when you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits
29e0cad
to
074c9a7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm at a first pass, but In this PR or in a follow-up PR we should consider how to surface problems with a condition on ClusterClass for:
- errors while calling extensions
- conflicts
79a2f76
to
879c60f
Compare
879c60f
to
ae92caa
Compare
/lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: 6775fb012d966995b36392c133b55d1ade307501
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last nit + a follow up
reconcileConditions(clusterClass, outdatedRefs) | ||
|
||
return ctrl.Result{}, nil | ||
} | ||
|
||
func (r *Reconciler) reconcileVariables(ctx context.Context, clusterClass *clusterv1.ClusterClass) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: when we implement support for more than one variable definition with the same name we need a unit test for this function alone, eventually injecting something that replace the actual runtime call for test pourposes.
Another option will be to split the call to runtime extension from computing status (before we call all runtime extensions storing results in some temporary struct, then we compute status processing all the results), so we can actually unit test compute status in isolation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note linking here to the umbrella issue.
ae92caa
to
b129a2b
Compare
b129a2b
to
15291d0
Compare
/retest |
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
LGTM label has been added. Git tree hash: 3b98b64a6b6760549a5ccf1428c9aaf8eefd0e3f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add the discoverVariables call to the External patch definition in the ClusterClass and add an implementation of the call in the ClusterClass reconciler.
Part of #7985