🐛 Remove exact path match from walkTemplate test #8019
Conversation
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
changed the title
| @@ -130,7 +130,7 @@ func Test_WalkTemplates(t *testing.T) { | |||
| CommonResponse: runtimehooksv1.CommonResponse{ | |||
| Status: runtimehooksv1.ResponseStatusFailure, | |||
| Message: "no kind \"Unknown\" is registered for version \"controlplane.cluster.x-k8s." + | |||
| "io/v1beta1\" in scheme \"pkg/runtime/scheme.go:100\"", | |||
There was a problem hiding this comment.
This issue was reported in slack where the path reported was "go/pkg/runtime.scheme.go". This can be safely changed without losing coverage. I'm currently digging to the bottom of how the path is generated to see why it might have ended up different here.
@mtougeron it would be great if you could outline how you had the packages set up, or whether this issue is hitting you on a clean main repo.
There was a problem hiding this comment.
I'm on MacOS
$> pwd
/Users/tougeron/src/go/src/github.com/mtougeron/cluster-api
$> env | grep GO
GOPATH=/Users/tougeron/src/go
FWIW, I just tried without setting my GOPATH and it worked as expected.
There was a problem hiding this comment.
Interesting - I wonder if any other tests are dependent on using go modules 🤔
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 258b5f56cc47e640f75560a00d15946cd59bcca9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Remove the exact path for the testScheme from the walkTemplates test. This change also renames the test file to correct a typo.