Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add DiscoverVariables hook implementation for test extension #8026

Merged
merged 1 commit into from
Mar 1, 2023
Merged

🌱 Add DiscoverVariables hook implementation for test extension #8026

merged 1 commit into from
Mar 1, 2023

Conversation

killianmuldoon
Copy link
Contributor

Add an initial implementation of the DiscoverVariables hook to the test extension.

Part of #7985

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from dc8e9a3 to f9bcbff Compare January 30, 2023 21:01
@killianmuldoon killianmuldoon mentioned this pull request Jan 30, 2023
Closed
34 tasks
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from d233eb4 to e74137d Compare January 31, 2023 15:51
@fabriziopandini
Copy link
Member

@killianmuldoon ping me when this one is ready for a pass

@killianmuldoon
Copy link
Contributor Author

killianmuldoon commented Feb 1, 2023 •
edited
Loading

@killianmuldoon ping me when this one is ready for a pass

Sure - there's a few PRs that probably need to be merged before this one is really worth looking at as it contains a bunch of those commits.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from e74137d to 60103f0 Compare February 3, 2023 12:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 3, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch 2 times, most recently from a0f9191 to 47d9502 Compare February 3, 2023 12:44
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 47d9502 to 22d2f98 Compare February 14, 2023 11:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 22d2f98 to 0ba68e3 Compare February 14, 2023 11:39
@killianmuldoon killianmuldoon mentioned this pull request Feb 15, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 0ba68e3 to 51d8411 Compare February 20, 2023 09:57
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 51d8411 to f80a5e6 Compare February 22, 2023 20:27
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from f80a5e6 to b4406a4 Compare February 28, 2023 13:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from b4406a4 to 5ad6f2f Compare February 28, 2023 14:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 5ad6f2f to 572cb1a Compare February 28, 2023 15:48
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Add DiscoverVariables hook implementation for test extension 🌱 Add DiscoverVariables hook implementation for test extension Feb 28, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from 572cb1a to ed70a92 Compare February 28, 2023 16:26
@killianmuldoon
Add e2e variables to test extension
717039a 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@killianmuldoon killianmuldoon force-pushed the pr-exvars-add-test-extension-hook branch from ed70a92 to 717039a Compare February 28, 2023 16:41
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a30c976af8673f8b7cb549aaf720ff8d1afeb89

@sbueringer
Copy link
Member

/lgtm
/approve

Let's get the basic test merged while we work on a more advanced test.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6fede8c into kubernetes-sigs:main Mar 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @fabriziopandini @sbueringer @k8s-ci-robot