Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add notes about IPv6 tests in the release tasks #8034

Conversation

furkatgofurov7
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2023
@furkatgofurov7 furkatgofurov7 force-pushed the note-IPv6-tests-in-release-tasks/furkat branch from a43c014 to 11dcbe5 Compare January 31, 2023 18:24
@furkatgofurov7
Copy link
Member Author

/assign @ykakarap
/cc @sbueringer

@sbueringer
Copy link
Member

sbueringer commented Jan 31, 2023

/lgtm
for me, if you want to do it. I could also live with we would notice that anyway when we review PRs and would then bring it up.

Jobs consistently failing on PRs are basically impossible to miss, compared to the periodics running in the background.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1413d3d6545af02e3476e78e1b601bbb260edf02

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Just one nit.

docs/release/release-tasks.md Outdated Show resolved Hide resolved
@furkatgofurov7 furkatgofurov7 force-pushed the note-IPv6-tests-in-release-tasks/furkat branch from 11dcbe5 to ac49928 Compare January 31, 2023 18:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@sbueringer
Copy link
Member

/approve

Leaving the fixup + lgtm to you folks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2023
@furkatgofurov7 furkatgofurov7 force-pushed the note-IPv6-tests-in-release-tasks/furkat branch from ac49928 to 0c166ea Compare January 31, 2023 18:42
@ykakarap
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c5be87e803036c362324c783a02d8ad324f4acac

@k8s-ci-robot k8s-ci-robot merged commit aa5eacf into kubernetes-sigs:main Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants