Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Stop supporting CRDs with invalid names #8041

Merged
merged 1 commit into from
Feb 7, 2023
Merged

⚠️ Stop supporting CRDs with invalid names #8041

merged 1 commit into from
Feb 7, 2023

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Feb 1, 2023 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5686

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 1, 2023
@sbueringer sbueringer force-pushed the pr-dont-support-crds-with-invalid-name branch 2 times, most recently from b7cb621 to fe66377 Compare February 1, 2023 15:37
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

fabriziopandini
fabriziopandini reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! nice cleanup!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 578c1e8bc935d102125d1b6efe802a3d03ff5ab7

@sbueringer
Copy link
Member Author

/assign @Jont828 @ykakarap

killianmuldoon
killianmuldoon reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/lgtm

Happy to approve when you think it's ready / has enough eyes on it.

@sbueringer
Copy link
Member Author

Yup I think we can merge, I think we won't get more reviews.

killianmuldoon
killianmuldoon approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@sbueringer
Stop supporting CRDs with invalid names
a639988 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-dont-support-crds-with-invalid-name branch from fe66377 to a639988 Compare February 7, 2023 16:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@sbueringer
Copy link
Member Author

@killianmuldoon Had to change a call to UpdateReferenceAPIContractwhich was introduced in the MachinePool controller in another PR

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 7, 2023 •
edited

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main a639988 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

killianmuldoon
killianmuldoon reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d392b2287002542dc88ebeb0850e68a7df7b4006

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c806d52 into kubernetes-sigs:main Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 7, 2023
@sbueringer sbueringer deleted the pr-dont-support-crds-with-invalid-name branch February 7, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@Jont828 Jont828 Awaiting requested review from Jont828

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@fabriziopandini fabriziopandini

@Jont828 Jont828

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Stop using full CRD list as a fallback to get ObjectMetadata for UpdateReferenceAPIContract
6 participants
@sbueringer @k8s-ci-robot @fabriziopandini @killianmuldoon @Jont828 @ykakarap