🐛: Make sure the Kubernetes API Server service already created on remote cluster before applying ClusterResourceSets

[Levi080513]

What this PR does / why we need it:
kube-apiserver select the first valid IP from ServiceClusterIPRange to use as the GenericAPIServer service IP, if apply ClusterResourceSet before default kubernetes service has beed created, the GenericAPIServer service IP may assign to other service and it will make default kubernetes service always create failed by service IP conflict.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #7804

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Levi080513 (1055e87)

[k8s-ci-robot]

Welcome @Levi080513!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Levi080513. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[killianmuldoon]

Thanks for the contribution @Levi080513! I have a few questions about this bug - would be great if you could chime in on the issue - #7804

[Levi080513]

@killianmuldoon done

[killianmuldoon]

Last round of nits from my side. @JessHu it would be great if you could review to ensure it solves the problem you've encountered.

[killianmuldoon]

Thanks @Levi080513!

/lgtm

[killianmuldoon]

@Levi080513 can you squash the commits when you get a chance?

[killianmuldoon]

Just a github rate limit flake

/retest

[Levi080513]

@Levi080513 can you squash the commits when you get a chance?

done

[jessehu]

Adding suggestion for wording and log msg.

[jessehu]

/retest

[Levi080513]

/retest

[killianmuldoon]

Just one small comment on the test. @Levi080513 do you want to open an issue to track if there's a requirement to solve the kube-dns part of this in a follow-up?

/lgtm

[killianmuldoon]

Sorry - still a couple of nits - hit the lgtm button too early 😅

[killianmuldoon]

/remove-lgtm

[Levi080513]

Just one small comment on the test. @Levi080513 do you want to open an issue to track if there's a requirement to solve the kube-dns part of this in a follow-up?

/lgtm

@killianmuldoon I will open an issue to track it, and this is still a problem.
But now I don't know what is the best solution to solve it.

[killianmuldoon]

Thanks for the fixups!

Could you squash the commits?

[Levi080513]

Thanks for the fixups!

Could you squash the commits?

done

[killianmuldoon]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e76a9ae94b5355d5ae57d5990c92c2a11243004e

[sbueringer]

/approve

/cherry-pick release-1.4

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #8286

In response to this:

/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: #8048 failed to apply on top of branch "release-1.3":

Applying: make sure Kubernetes API Server service of remote cluster has been created before applying the ClusterResourceSet.
Using index info to reconstruct a base tree...
M	exp/addons/internal/controllers/clusterresourceset_controller.go
M	exp/addons/internal/controllers/clusterresourceset_controller_test.go
M	exp/addons/internal/controllers/clusterresourceset_helpers.go
M	exp/addons/internal/controllers/clusterresourceset_helpers_test.go
Falling back to patching base and 3-way merge...
Auto-merging exp/addons/internal/controllers/clusterresourceset_helpers_test.go
Auto-merging exp/addons/internal/controllers/clusterresourceset_helpers.go
CONFLICT (content): Merge conflict in exp/addons/internal/controllers/clusterresourceset_helpers.go
Auto-merging exp/addons/internal/controllers/clusterresourceset_controller_test.go
CONFLICT (content): Merge conflict in exp/addons/internal/controllers/clusterresourceset_controller_test.go
Auto-merging exp/addons/internal/controllers/clusterresourceset_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 make sure Kubernetes API Server service of remote cluster has been created before applying the ClusterResourceSet.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[johannesfrey]

/area clusterresourceset