🌱 hack: add support for date ranges to notes.go script

[oscr]

What this PR does / why we need it:

This is useful for the comms team when creating the weekly updates for the slack channel. Example invocation and output:

$ go run hack/tools/release/notes.go --since 2023-02-06 --until 2023-02-12
Changes since 2023-02-06 - 2023-02-12
---
## :warning: Breaking Changes
- Stop supporting CRDs with invalid names (#8041)

## :sparkles: New Features
- Add discoverVariables runtime hook to ClusterClass reconcile loop (#8006)
- Update coredns corefile migration to v1.0.19 (#8074)

## :bug: Bug Fixes
- uplift helm dependency (#8089)
- KCP: Allow unsetting fields if their child fields are mutable (#8037)
- Added nodeVolumeDetachTimeout to CP machine (#8066)
- ClusterCacheTracker: fix panic in error creation (#8062)

## :seedling: Others
- Add ClusterClass generation check to Cluster Topology reconciler (#8023)
- MD: improve replica defaulting for autoscaler (#7990)
- Add clusterclass validation to topology reconciler (#7954)
- ClusterClass: catch panics when applying patches (#8067)
- Bump golangci-lint (v1.51.1) and enable some ginkgolinter checks (#8058)
- test/e2e use informer to stream pod logs (#7935)

:book: Additionally, there have been 1 contributions to our documentation and book. (#8079) 


_Thanks to all our contributors!_ 😊

cc @joekr @sayantani11 @VibhorChinda

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[joekr]

From the above output Changes since 0x4d0580 should that be a date in the format yyyy-mm-dd?

[oscr]

From the above output Changes since 0x4d0580 should that be a date in the format yyyy-mm-dd?

@joekr Thank you for pointing that out. It's fixed and description is updated :)

[oscr]

I noticed the count was different from when checking (GitHub prs](https://github.com/kubernetes-sigs/cluster-api/pulls?q=is%3Apr+is%3Aclosed+milestone%3Av1.4+closed%3A2023-02-06..2023-02-12). It seems like there is a small gotcha here with until doesn't include the last date. So it needs to be run go run hack/tools/release/notes.go --since 2023-02-06 --until 2023-02-13 right now to give the same result.

[joekr]

So it needs to be run go run hack/tools/release/notes.go --since 2023-02-06 --until 2023-02-13 right now to give the same result.

If that is the case what do you think about updating the flag.string or at least an comment to call this out?

[oscr]

Great suggestion @joekr! Added.

[oscr]

/retest

[sbueringer]

Thx!

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c6d01b0b945e18107cac495d46f29edc33d7cf17

[oscr]

/retest

[richardcase]

I'm not overly keen on exposing the same names as git (i.e. since/until) and think something else like from/to is more intuitive. But thats a personal preference only.

I have run this locally with various args and it works as expected. From my side:

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 130942ab332db480e174814e25f91e8254bf0064

[sbueringer]

last nit from my side

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9b104c9cbbdca8703c72d14b39911c9eeb48fa72

[oscr]

I'm not overly keen on exposing the same names as git (i.e. since/until) and think something else like from/to is more intuitive. But thats a personal preference only.

@richardcase I appreciate this feedback and I kind of agree with you. From a user perspective it makes a lot of sense to have from/to and I generally prefer it. The question is how "thin" this script should be. I tried to keep it as a minimal extension of git and wanted to avoid touching the existing from flag. But maybe you are right about we should stop exposing git names. There will be more changes to the script in the near future by the comms team and I will keep this in mind.

[richardcase]

@oscr - that all sounds good to me 👍

[killianmuldoon]

Small nit on the comments.

[killianmuldoon]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a29ca3c3e440d25dc78b43b2497eb73f42ceab79

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment