-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 hack: add support for date ranges to notes.go script #8094
🌱 hack: add support for date ranges to notes.go script #8094
Conversation
a10e0a2
to
409ec37
Compare
From the above output |
@joekr Thank you for pointing that out. It's fixed and description is updated :) |
I noticed the count was different from when checking (GitHub prs](https://github.com/kubernetes-sigs/cluster-api/pulls?q=is%3Apr+is%3Aclosed+milestone%3Av1.4+closed%3A2023-02-06..2023-02-12). It seems like there is a small gotcha here with until doesn't include the last date. So it needs to be run |
If that is the case what do you think about updating the |
409ec37
to
bae0931
Compare
Great suggestion @joekr! Added. |
bae0931
to
49d64d4
Compare
/retest |
Thx! /lgtm |
LGTM label has been added. Git tree hash: c6d01b0b945e18107cac495d46f29edc33d7cf17
|
49d64d4
to
ddb4194
Compare
db2e067
to
b88209b
Compare
/retest |
b88209b
to
942eb3f
Compare
I'm not overly keen on exposing the same names as git (i.e. I have run this locally with various args and it works as expected. From my side: /lgtm |
LGTM label has been added. Git tree hash: 130942ab332db480e174814e25f91e8254bf0064
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nit from my side
942eb3f
to
446ebd4
Compare
/lgtm |
LGTM label has been added. Git tree hash: 9b104c9cbbdca8703c72d14b39911c9eeb48fa72
|
@richardcase I appreciate this feedback and I kind of agree with you. From a user perspective it makes a lot of sense to have |
@oscr - that all sounds good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit on the comments.
This is useful for the comms team when creating the weekly updates for the slack channel. Example invocation would be: `go run hack/tools/release/notes.go --since 2023-02-06 --until 2023-02-12`
446ebd4
to
6d80352
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: a29ca3c3e440d25dc78b43b2497eb73f42ceab79
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is useful for the comms team when creating the weekly updates for the slack channel. Example invocation and output:
cc @joekr @sayantani11 @VibhorChinda
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #