Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 docs: document plan to remove v1alpha3 and v1alpha4 apiVersions #8117

Merged
merged 1 commit into from
Feb 22, 2023
Merged

📖 docs: document plan to remove v1alpha3 and v1alpha4 apiVersions #8117

merged 1 commit into from
Feb 22, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8038

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2023
@sbueringer sbueringer mentioned this pull request Feb 15, 2023
Closed
18 tasks
@sbueringer
Copy link
Member Author

sbueringer commented Feb 15, 2023 •
edited
Loading

cc @CecileRobertMichon @enxebre @fabriziopandini @killianmuldoon @vincepri

I've opened a PR to document the removal plan: #8117
I will also ask for a lazy consensus for the PR in the office hours today to "formalize" the approval of the plan
#8038 (comment)

killianmuldoon
killianmuldoon reviewed Feb 15, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
killianmuldoon
killianmuldoon reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of clarification in the text - otherwise looks good IMO.

killianmuldoon
killianmuldoon approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6aa3d05dbb8b5e035c5f29c409a0afe38c34e25

@elmiko
Copy link
Contributor

elmiko commented Feb 15, 2023

starting lazy consensus from community meeting, 1 week from today (target Feb 22)

fabriziopandini
fabriziopandini reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two nits, otherwise lgtm from my side

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
docs: document plan to remove v1alpha3 and v1alpha4 apiVersions
068b2f2 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@sbueringer
Copy link
Member Author

Thx for the review. Findings should be addressed

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca7ad0abb712622f0281420366b6c53086baa4e5

@CecileRobertMichon
Copy link
Contributor

/lgtm

@sbueringer
Copy link
Member Author

/approve
given lazy consensus and lgtm's above

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9c9202e into kubernetes-sigs:main Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 22, 2023
@sbueringer sbueringer deleted the pr-document-apiversion-removal branch February 22, 2023 05:06
@sbueringer
Copy link
Member Author

/cherry-pick release-1.3

to get the contributing.md changes in the book

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 22, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #8150

In response to this:

/cherry-pick release-1.3

to get the contributing.md changes in the book

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@enxebre enxebre Awaiting requested review from enxebre

@vincepri vincepri Awaiting requested review from vincepri

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@sbueringer @k8s-ci-robot @elmiko @fabriziopandini @CecileRobertMichon @k8s-infra-cherrypick-robot @killianmuldoon