Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 MD controller: fix nil pointer when OnDelete policy is used #8184

Merged
merged 1 commit into from
Feb 27, 2023
Merged

🐛 MD controller: fix nil pointer when OnDelete policy is used #8184

merged 1 commit into from
Feb 27, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
MD controller: fix nil pointer when OnDelete policy is used
e9a265f 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2023
@sbueringer
Copy link
Member Author

/assign @ykakarap @fabriziopandini

@sbueringer
Copy link
Member Author

/retest

1 similar comment
@sbueringer
Copy link
Member Author

/retest

ykakarap
ykakarap approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: afedb154a2234edc68e22e45a39653204c5be2e3

killianmuldoon
killianmuldoon reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5ce87b6 into kubernetes-sigs:main Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 27, 2023
@sbueringer sbueringer deleted the pr-md-fix-nil-pointer branch February 27, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@ykakarap ykakarap ykakarap approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbueringer @k8s-ci-robot @ykakarap @killianmuldoon @fabriziopandini