Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ MachineDeployment rolloutAfter support #8216

Merged
merged 1 commit into from
Mar 9, 2023
Merged

✨ MachineDeployment rolloutAfter support #8216

merged 1 commit into from
Mar 9, 2023

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Mar 2, 2023

What this PR does / why we need it:

This PR adds rolloutAfter support to MachineDeployments.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #7731

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2023
@ykakarap ykakarap changed the title ✨ MachineDeployment rolloutAfter support ✨ [WIP] MachineDeployment rolloutAfter support Mar 2, 2023
@ykakarap ykakarap mentioned this pull request Mar 2, 2023
Closed
19 tasks
@ykakarap ykakarap force-pushed the machinedeployment-rollout-after branch from 6fc2173 to 9a67a0c Compare March 2, 2023 10:16
@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 2, 2023

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

sbueringer
sbueringer reviewed Mar 3, 2023
View reviewed changes
api/v1alpha3/conversion.go Outdated Show resolved Hide resolved
docs/book/src/tasks/upgrading-clusters.md Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/mdutil/util.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/mdutil/util.go Outdated Show resolved Hide resolved
internal/controllers/machinedeployment/mdutil/util_test.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the machinedeployment-rollout-after branch 2 times, most recently from d9a2058 to cc5a898 Compare March 5, 2023 19:01
@ykakarap ykakarap changed the title ✨ [WIP] MachineDeployment rolloutAfter support ✨ MachineDeployment rolloutAfter support Mar 5, 2023
@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 5, 2023

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 5, 2023

/retest

@sbueringer
Copy link
Member

Thx!

/lgtm
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3e8aab358418aa44e5fed0a96c2d9d7d482aac2

fabriziopandini
fabriziopandini reviewed Mar 6, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this PR!
I'm +1 for this implementation, but given discussions on recent PRs, let's ask for more opinions about changes to the hash label. Might be worth bringing up the topic at office hours as well.

api/v1beta1/machinedeployment_types.go Show resolved Hide resolved
@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 6, 2023

Might be worth bringing up the topic at office hours as well.

I will add it to this week's office hours agenda.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@ykakarap ykakarap force-pushed the machinedeployment-rollout-after branch from cc5a898 to 7bcac4c Compare March 8, 2023 07:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcae014798ea130967c575cbd83bdc26dd094cbc

@enxebre
Copy link
Member

enxebre commented Mar 8, 2023

thanks!
/lgtm

CecileRobertMichon
CecileRobertMichon reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ykakarap ykakarap force-pushed the machinedeployment-rollout-after branch from 7bcac4c to 99d7559 Compare March 9, 2023 04:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 9, 2023 •
edited

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main 99d7559 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

Thx everyone!

/retest
(unrelated flakes)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 675cee1e889593ea98d4a6a54ed7e50f1be905ac

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit ad11058 into kubernetes-sigs:main Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 9, 2023
@sbueringer sbueringer mentioned this pull request Mar 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ykakarap @sbueringer @k8s-ci-robot @enxebre @fabriziopandini @CecileRobertMichon