[release-1.2] 🐛 bugfix function aggregateFromMachinesToKCP

[jackfrancis]

This is a manual cherry-pick of #8132 into release-1.2.

Credit to @wm775825 for the fix!

[sbueringer]

Thx for cherry-picking!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9be1570c965c6fb050d4e8bc018653a35816c5ad

[sbueringer]

@jackfrancis looks like the linter is not happy. I would suggest to just add a lint ignore. I think we dropped this linter on main already

[jackfrancis]

@sbueringer what's funny is that the linter appears to be wrong, as those vars are indeed referenced outside the modified if statement (in the case switch above).

[sbueringer]

Yeah that's roughly the reason why we dropped the linter :D

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 8339f3f962977f7b367fdd07e3a12e988ec6937e

[sbueringer]

Yeah that's roughly the reason why we dropped the linter :D

@jackfrancis Was no fun to try to debug this: esimonov/ifshort#23
(+ linter is apparently archived now)