🐛 Ensure all GitHub releases are fetched when searching provider versions

[abhay-krishna]

What this PR does / why we need it:
This PR improves the logic of fetching GitHub releases when looking for versions in provider repositories. The ListReleases API call is paginated and returns only the latest 30 releases. So we need to issue multiple calls in series to fetch all releases for a repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8233 (NOTE: This PR handles only GitHub, it doesn't include a GitLab fix.)

[k8s-ci-robot]

Hi @abhay-krishna. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/assign @ykakarap @Jont828

[abhay-krishna]

@sbueringer @ykakarap If I rebase and push, it'll remove the lgtm label, and I'll need to 🐛 the maintainers again, so holding off on doing so. There are no conflicts here (yet), so should be a clean merge either way.

[ykakarap]

I don't see any conflicts and looks like all the commits are squashed. Is there a need to rebase?

[sbueringer]

/assign @fabriziopandini
If you have some time, would be great if you can take over the final review/approval

[CecileRobertMichon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/clusterctl/OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@CecileRobertMichon @ykakarap Does it make sense to backport this as a bug fix?

[jackfrancis]

@sbueringer You didn't ask for my opinion, but here it is anyways :)

@killianmuldoon said in the issue description:

This should be fixed in supported versions of Cluster API as we don't control the number of releases done by providers and different approaches e.g. many published pre-releases, could result in an older supported version not being installable.

That suggests a backport to the set of branches that can cut patch releases for "supported versions", right?

[sbueringer]

@sbueringer You didn't ask for my opinion, but here it is anyways :)

Always appreciated :)

Sounds good

[sbueringer]

/cherry-pick release-1.4

[sbueringer]

/cherry-pick release-1.3

[sbueringer]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #8329

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #8240 failed to apply on top of branch "release-1.3":

Applying: Ensure all GitHub releases are fetched when searching provider versions
Using index info to reconstruct a base tree...
M	cmd/clusterctl/client/repository/repository_github.go
M	cmd/clusterctl/client/repository/repository_github_test.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/clusterctl/client/repository/repository_github_test.go
CONFLICT (content): Merge conflict in cmd/clusterctl/client/repository/repository_github_test.go
Auto-merging cmd/clusterctl/client/repository/repository_github.go
CONFLICT (content): Merge conflict in cmd/clusterctl/client/repository/repository_github.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure all GitHub releases are fetched when searching provider versions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #8240 failed to apply on top of branch "release-1.2":

Applying: Ensure all GitHub releases are fetched when searching provider versions
Using index info to reconstruct a base tree...
M	cmd/clusterctl/client/repository/repository_github.go
M	cmd/clusterctl/client/repository/repository_github_test.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/clusterctl/client/repository/repository_github_test.go
CONFLICT (content): Merge conflict in cmd/clusterctl/client/repository/repository_github_test.go
Auto-merging cmd/clusterctl/client/repository/repository_github.go
CONFLICT (content): Merge conflict in cmd/clusterctl/client/repository/repository_github.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure all GitHub releases are fetched when searching provider versions
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Would be great if someone can create cherry-picks for 1.3 and 1.2

[sbueringer]

1.3 is merging now, this leaves 1.2

[ykakarap]

I can do the release-1.2 cherry-pick.

[johannesfrey]

/area clusterctl