Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 book: extend next steps of quick start #8252

Merged
merged 1 commit into from
Mar 15, 2023
Merged

📖 book: extend next steps of quick start #8252

merged 1 commit into from
Mar 15, 2023

Conversation

Sajiyah-Salat
Copy link
Contributor

@Sajiyah-Salat Sajiyah-Salat commented Mar 8, 2023 •
edited
Loading

What this PR does / why we need it:
in quick start there was info for first cluster but second cluster info was missing I have just added that.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8152

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Sajiyah-Salat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon
killianmuldoon reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Just a couple of nits to clear up.

docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Show resolved Hide resolved
killianmuldoon
killianmuldoon approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72b5300220c5cb6b8be7a86941a41879fb3cf961

@sbueringer
Copy link
Member

/retitle ✨book: update quick-start.md

/lgtm

/assign @oscr

@k8s-ci-robot k8s-ci-robot changed the title ✨Update quick-start.md ✨book: update quick-start.md Mar 8, 2023
@sbueringer
Copy link
Member

/retitle ✨book: extend next steps of quick start

@k8s-ci-robot k8s-ci-robot changed the title ✨book: update quick-start.md ✨book: extend next steps of quick start Mar 8, 2023
@sbueringer sbueringer changed the title ✨book: extend next steps of quick start 📖 book: extend next steps of quick start Mar 8, 2023
@CecileRobertMichon
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2023
CecileRobertMichon
CecileRobertMichon reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Sajiyah-Salat could you please squash commits?

@oscr
Copy link
Contributor

oscr commented Mar 8, 2023 •
edited
Loading

@Sajiyah-Salat could you please squash commits?

@Sajiyah-Salat Here is a description how to squash commits from our contributing guide.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2023
@Sajiyah-Salat
Copy link
Contributor Author

I am stuck here. I have squashed my commits. but I dont know from where this other commint came.

@Sajiyah-Salat Sajiyah-Salat force-pushed the sajiyah-#8152 branch 2 times, most recently from ddbfbc6 to 8842703 Compare March 14, 2023 15:35
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 14, 2023 •
edited
Loading

@Sajiyah-Salat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-test-main 8842703 link true /test pull-cluster-api-test-main
pull-cluster-api-e2e-main 8842703 link true /test pull-cluster-api-e2e-main
pull-cluster-api-test-mink8s-main 8842703 link true /test pull-cluster-api-test-mink8s-main
pull-cluster-api-apidiff-main 8842703 link false /test pull-cluster-api-apidiff-main
pull-cluster-api-e2e-informing-main 8842703 link false /test pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-informing-ipv6-main 8842703 link false /test pull-cluster-api-e2e-informing-ipv6-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@killianmuldoon
Copy link
Contributor

@Sajiyah-Salat - if you're stuck with the rebase process you can start again from main, add your changes to the quick-start and then force-push the changes to this branch. That will give you a full reset with only the changes you want.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 15, 2023
@oscr
Copy link
Contributor

oscr commented Mar 15, 2023

Great work!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1e8a41beff7ec11a7a95d533ee5894ff07632869

killianmuldoon
killianmuldoon reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for the contribution @Sajiyah-Salat!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/retest

@Sajiyah-Salat @killianmuldoon
extend next steps of quick start
f519d95 
Update docs/book/src/user/quick-start.md

Co-authored-by: killianmuldoon <47175296+killianmuldoon@users.noreply.github.com>

Update docs/book/src/user/quick-start.md

Co-authored-by: killianmuldoon <47175296+killianmuldoon@users.noreply.github.com>

Update docs/book/src/user/quick-start.md

Co-authored-by: killianmuldoon <47175296+killianmuldoon@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot merged commit 323e257 into kubernetes-sigs:main Mar 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 15, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 15, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8295

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 15, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8296

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@oscr oscr Awaiting requested review from oscr

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@oscr oscr

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

book create just one cluster
7 participants
@Sajiyah-Salat @k8s-ci-robot @sbueringer @CecileRobertMichon @oscr @killianmuldoon @k8s-infra-cherrypick-robot