Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Ensure ownerReference apiVersions are always up to date #8256

Merged
merged 1 commit into from
Mar 22, 2023
Merged

🐛 Ensure ownerReference apiVersions are always up to date #8256

merged 1 commit into from
Mar 22, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Mar 9, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7224

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2023
@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 3 times, most recently from 5b4205f to 44c7c80 Compare March 15, 2023 13:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 15, 2023
@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 3 times, most recently from 5d4df8f to cee89d9 Compare March 16, 2023 13:51
@killianmuldoon killianmuldoon changed the title [WIP] OwnerReferences apiVersion update [WIP] 🐛 OwnerReferences apiVersion update Mar 16, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 5 times, most recently from 30c3b8b to 9ff80cb Compare March 16, 2023 15:21
@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 2 times, most recently from 3870310 to 585e908 Compare March 16, 2023 16:14
@killianmuldoon killianmuldoon mentioned this pull request Mar 16, 2023
Closed
@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 6 times, most recently from 3b905f0 to 9d6e1cf Compare March 17, 2023 14:31
@killianmuldoon killianmuldoon force-pushed the pr-test-ownerref branch 2 times, most recently from 1fdf7e5 to 90f9dfe Compare March 21, 2023 19:16
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Copy link
Contributor Author

/retest

1 similar comment
@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

Interesting

Unexpected ownerReferences for ClusterResourceSetBinding/clusterctl-upgrade-evj198: wanted [addons.cluster.x-k8s.io/v1beta1, Kind=ClusterResourceSet], actual [cluster.x-k8s.io/v1alpha3, Kind=Cluster addons.cluster.x-k8s.io/v1beta1, Kind=ClusterResourceSet]

@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon
Copy link
Contributor Author

Interesting

Unexpected ownerReferences for ClusterResourceSetBinding/clusterctl-upgrade-evj198: wanted [addons.cluster.x-k8s.io/v1beta1, Kind=ClusterResourceSet], actual [cluster.x-k8s.io/v1alpha3, Kind=Cluster addons.cluster.x-k8s.io/v1beta1, Kind=ClusterResourceSet]

This seems to be working for me locally - so I'm trying to see if it's just a flake.

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for e2e-full

Thank you very much for working on this! And again improving quality and test coverage significantly!!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 638b66505d504be735b3f321fc9a7c5c60061ff5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@killianmuldoon
Copy link
Contributor Author

/hold cancel

Passing the full e2e tests now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 54503f5 into kubernetes-sigs:main Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 22, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 22, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #8338

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/area api

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jun 27, 2023
@killianmuldoon killianmuldoon mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

CAPI controllers should keep ownerRefs on the current apiVersion
5 participants
@killianmuldoon @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot @fabriziopandini