Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 replace reflect deepequal in bootstrap kubeadm #8266

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

DiptoChakrabarty
Copy link
Member

What this PR does / why we need it:
replacing reflect.deepequal with cmp.Diff to which provides better diff for debugging purposes
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8186

This PR is for bootstrap/kubeadm will be following up with more

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2023
@sbueringer
Copy link
Member

sbueringer commented Mar 14, 2023

Let's wait with merging this until we branched v1.4 away later today

I would prefer not rushing this into this release so we can have it together with subsequent/corresponding changes in the next one

@sbueringer
Copy link
Member

Just realized that this PR is only touching test code. I think then it doesn't matter if this PR goes in before or after we cut the release branch

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 10d4dba46071bb7508ca5d3e4130e9934e533e93

@g-gaston
Copy link
Contributor

/lgtm

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@killianmuldoon
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9aa0f9f into kubernetes-sigs:main Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 14, 2023
@johannesfrey
Copy link
Contributor

/area provider/bootstrap-kubeadm

@k8s-ci-robot k8s-ci-robot added the area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider replacing reflect.DeepEqual
6 participants