Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: add link to release 1.4 in capi book #8307

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Mar 18, 2023

What this PR does / why we need it:

Adds link to the 1.4 release in CAPI book.

Should be merged after production branch is updated to 1.4 in Netlfiy
/hold

cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0cd69d53ecec3a725e1c8e38a0ee8996bec1dd4

@sbueringer
Copy link
Member

sbueringer commented Mar 20, 2023

/lgtm
/approve

@oscr Why not merge now? Merging this PR only affects the main/release-1.5 book

(The production branch will be changed from release-1.3 to release-1.4 so it doesn't involve what we have on main)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscr
Copy link
Contributor Author

oscr commented Mar 20, 2023

@oscr Why not merge now? Merging this PR only affects the main/release-1.5 book

Sounds good to me!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 83c31f4 into kubernetes-sigs:main Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants