Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 docs: update CAPI support and guarantees #8308

Merged
merged 1 commit into from
Mar 28, 2023
Merged

📖 docs: update CAPI support and guarantees #8308

merged 1 commit into from
Mar 28, 2023

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Mar 18, 2023 •
edited

What this PR does / why we need it:

Update support and guarantees

cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2023
killianmuldoon
killianmuldoon approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Until the release date passes so we don't have to update 😅

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a3cd134df019ff77b3c9fb05e8bf78b9c8fceb59

@sbueringer
Copy link
Member

/lgtm
/approve

Not sure I understand why we want to hold. I assume so we don't have to update in case we can't make the release date?
(but of course I'm fine with holding :))

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2023
furkatgofurov7
furkatgofurov7 reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fabriziopandini
fabriziopandini reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this PR
Also, what about adding EOL on all the mentions to 1.2 in https://cluster-api.sigs.k8s.io/reference/versions.html; ideally we should also drop 1.1 columns and add 1.5 columns, but I'll defer to you if to do this in one PR or to split the work

CONTRIBUTING.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2023
@oscr oscr changed the title 📖 docs: update CAPI support and guarantees. Add 1.4 and set 1.2 EOL date 📖 docs: update CAPI support and guarantees Mar 23, 2023
@fabriziopandini
Copy link
Member

great work!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 35909e671be88a043867866080482e09e6021ff1

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit df74799 into kubernetes-sigs:main Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 28, 2023
@chrischdi chrischdi mentioned this pull request Aug 2, 2023
Closed
29 tasks
@sbueringer sbueringer mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oscr @k8s-ci-robot @sbueringer @fabriziopandini @killianmuldoon @furkatgofurov7