🐛 Validate variables in defaulting webhook #8332
Conversation
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
force-pushed
the
pr-validate-variables-in-default-webhook
branch
2 times, most recently
from
7250c0a
to
246de8a
Compare
|
/retest |
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-validate-variables-in-default-webhook
branch
from
246de8a
to
43e229f
Compare
|
/lgtm /test pull-cluster-api-e2e-full-main /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 520c0ad4ec31694beea5eb1a6daf8f6a5c459c0c
|
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.4 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@sbueringer: new pull request created: #8345 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/area clusterclass |
Move variable validation from the Cluster validation webhook to the Cluster defaulting webhook
This fixes a race condition caused by moving variable definitions from ClusterClass spec to status. That change means there is a chance that the defaulting and validating webhook are working off of different versions of the ClusterClass as each independently retrieves it from the cache.
Fixes #