🐛 Fix length check in MD helper

[killianmuldoon]

Update the length checking in the machineDeployment helpers.
Should fix issues with the clusterctl upgrade e2e tests.

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 3833ee619534f8f2e9147bdf1aac4058b3b22473

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@killianmuldoon Should we cherry-pick this?

[killianmuldoon]

Could be useful - good catch.

[killianmuldoon]

/cherry-pick release-1.3

[k8s-infra-cherrypick-robot]

@killianmuldoon: #8352 failed to apply on top of branch "release-1.3":

Applying: Fix length check in MD helper
Using index info to reconstruct a base tree...
M	test/framework/machinedeployment_helpers.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/machinedeployment_helpers.go
CONFLICT (content): Merge conflict in test/framework/machinedeployment_helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix length check in MD helper
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Could be useful - good catch.

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: #8352 failed to apply on top of branch "release-1.3":

Applying: Fix length check in MD helper
Using index info to reconstruct a base tree...
M	test/framework/machinedeployment_helpers.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/machinedeployment_helpers.go
CONFLICT (content): Merge conflict in test/framework/machinedeployment_helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix length check in MD helper
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

This issue was introduced in #8331 so no need for a backport.

[johannesfrey]

/area e2e-testing