Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 set uninitialized taint only on worker nodes #8358

Merged
merged 1 commit into from
Mar 24, 2023
Merged

🐛 set uninitialized taint only on worker nodes #8358

merged 1 commit into from
Mar 24, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

Apply the node.cluster.x-k8s.io/uninitialized:NoSchedule only to worker nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8357

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 24, 2023
@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 24, 2023 •
edited

/hold
until we have consensus on a preferred solution.

Ref: #8357 (comment)

@fabriziopandini
Copy link
Member

fabriziopandini commented Mar 24, 2023 •
edited

Do you mind adding a small clarification also in https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20220927-label-sync-between-machine-and-nodes.md#delay-between-node-create-and-label-sync
Otherwise lgtm

@fabriziopandini fabriziopandini mentioned this pull request Mar 24, 2023
Closed
@ykakarap ykakarap force-pushed the unitialized-worker-nodes-only branch from f871e69 to 1bb9bca Compare March 24, 2023 15:27
@ykakarap
Copy link
Contributor Author

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@ykakarap: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9392aa91af6e686e8a1a9e71766ef098360237b1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@ykakarap
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9e48879 into kubernetes-sigs:main Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 24, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@ykakarap: new pull request created: #8371

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johannesfrey
Copy link
Contributor

/area provider/bootstrap-kubeadm

@k8s-ci-robot k8s-ci-robot added the area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/bootstrap-kubeadm Issues or PRs related to CAPBK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

node.cluster.x-k8s.io/uninitialized cause race condition when creating cluster.
5 participants
@ykakarap @fabriziopandini @k8s-infra-cherrypick-robot @k8s-ci-robot @johannesfrey