🐛 Fix flake in machine phases test #8370
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
k8s-ci-robot
added
area/testing
|
/cherry-pick release-1.4 |
k8s-ci-robot
added
the
size/XS
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
No need to backport further as I think this flake was introduced in #8044 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f6165eb3e81a1f0496844071edda598246e9de19
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
@killianmuldoon: new pull request created: #8372 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nice catch! |
Fix for a flake in the machine phases test. The eventually call was using the wrong gomega matcher which made it fail the first time around.
/area testing