-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 🌱 Bump github.com/onsi/gomega from 1.27.4 to 1.27.5 #8402
[release-1.4] 🌱 Bump github.com/onsi/gomega from 1.27.4 to 1.27.5 #8402
Conversation
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.27.4 to 1.27.5. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.27.4...v1.27.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: d62a39985c73841f3cf3f1bd55c880dbf71781bc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Sure - no issues with that |
/retest |
/hold cancel |
I think the idea was to not backport all bumps, is there a specific reason for this one? |
I don't think there was a specific motivation - more just a preference for bumping stuff when it's easy. Will be more conservative in future. |
Yeah no problem. IIRC we updated the policy recently so we only backport if we have a reason like CVE's: https://cluster-api.sigs.k8s.io/contributing#backporting-a-patch
Otherwise we get a flood of cherry-picks for dependencies for all supported branches. (also some of those cherry-picks would propagate to CAPI consumers) |
This is an automated cherry-pick of #8390
/assign killianmuldoon