🐛 update TopologyReconciled condition on cluster deletion

[cahillsf]

What this PR does / why we need it:
Sets TopologyReconciled status condition to False on cluster deletion

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7926

[k8s-ci-robot]

Hi @cahillsf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[killianmuldoon]

Thanks for this @cahillsf! Once you think this is ready can you move it out of draft and I'll review

[cahillsf]

sounds good, thanks @killianmuldoon. Do you think this current fix does what's required?

I believe it should address the behavior described and False seems like the correct condition to set based on the description of a False status as, on recognizing the DeletionTimestamp, the topology cluster controller stops reconciling and leaves the other controllers to perform the deletion (src link).

If you agree, then I will add a test and move it out of draft.

[killianmuldoon]

I think you're right that marking as False with Severity Info and the reason being the cluster being deleted is the correct condition in this case.

[ykakarap]

Overall LGTM.

There are lint issues in this PR.
The linter job has not been triggered for this PR as it needs approval from a maintainer to trigger it, @killianmuldoon can you approve the job?

In the mean time @cahillsf, you can run make lint locally and fix the reported issues.

LGTM pending lint fix.

[cahillsf]

@ykakarap 👋 seems the lint check has run and passed without further intervention this time around

[ykakarap]

Thank you!

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e20f57780b386baf684db856a487208a9fb4b5da

[vincepri]

/hold

can you squash commits?

[sbueringer]

/lgtm

[vincepri]

/hold cancel
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cahillsf]

hey @vincepri 👋 thanks for taking a look -- seeing some inconsistent messaging in the test results, tide is indicating:
> Pending — Not mergeable. Job pull-cluster-api-build-main has not succeeded.

But that job (pull-cluster-api-build-main) is indicating success:
> pull-cluster-api-build-main — Job succeeded.

Am I missing something or is this unexpected behavior?

this looks to be resolved

---

Also seeing 1 workflow awaiting approval is this something you can approve?

[ykakarap]

One of the maintainers will have to approve the job. @sbueringer, can you help with this?

[killianmuldoon]

/area clusterclass