-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Switch cloudbuild.yaml to e2 machine type #8428
🌱 Switch cloudbuild.yaml to e2 machine type #8428
Conversation
Welcome @TerryHowe! |
Hi @TerryHowe. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
If we want to change this we should probably change it in |
+1 to stay in in sync with kk |
Done |
Could you squash the commits? |
Signed-off-by: Terry Howe <tlhowe@amazon.com>
000623c
to
564a3b5
Compare
Done |
/lgtm |
LGTM label has been added. Git tree hash: 712565f3c839c911b0a85b876c1beb32ac0db9af
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.4 |
/cherry-pick release-1.3 |
/cherry-pick release-1.2 |
@fabriziopandini: new pull request created: #8448 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: new pull request created: #8449 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: new pull request created: #8450 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do we need cherry-picks for these? I thought these jobs were only run on the main branch? |
The nightly build is only run on main. The regular one on main and on tags (pretty sure this is part of our release process). So I think the cherry-picks made sense. Did we communicate this to providers? A lot of providers are using cloud-build as well. (Probably all that are using the Kubernetes infrastructure for image publishing/promotion) |
We didn't communicate this - will add it to the CAPI meeting for this week. |
/area ci |
What this PR does / why we need it:
n1 machine times are old and e2 are going to be cheaper.
Reference kubernetes/k8s.io#5059