🌱 prepare main branch for v1.5 development #8430

joekr · 2023-03-31T01:22:48Z

What this PR does / why we need it:
This PR prepares the main branch for development.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #8429

joekr · 2023-03-31T01:23:52Z

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main
/test pull-cluster-api-e2e-full-main

fabriziopandini

@joekr thanks for opening this PR

from a quick look to failures in docker.yaml we need to bump also test extension (line 284 in the file before this PR), creating one entry for v1.4.0 fetching from release and renaming the current entry to 1.5.99

Now, there will be an issue probably, because we are not publishing manifests for the test extension yet, so we have to think a little bit about how to solve this (the easiest way is to fixup the release machinery and publish it ex-post).
@killianmuldoon @ykakarap opinions?

killianmuldoon · 2023-03-31T10:41:40Z

#8438
Adds the target to the release. We could manually add a the manifest to v1.4.0 as an oversight, or we could wait to include it in v1.4.1 - thoughts @fabriziopandini @joekr ?

fabriziopandini · 2023-03-31T12:52:29Z

I will add runtime-extension-components-development.yaml to the 1.4.0 release, the sooner we get this PR merged, the better

joekr · 2023-03-31T15:17:18Z

retesting after the last push.

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main
/test pull-cluster-api-e2e-full-main

killianmuldoon · 2023-03-31T15:47:41Z

You also need to update the clusterctl_upgrade_test.go with the correct versions e.g. - https://github.com/kubernetes-sigs/cluster-api/pull/8420/files#diff-a5ba4f7f8baf6fc4eabea488d3a79a7b9c6f56457783f2422aab591fce31bfd4

joekr · 2023-03-31T23:34:10Z

I ran GINKGO_FOCUS="When testing clusterctl upgrades (v1.2=>current)" ./scripts/ci-e2e.sh locally and it passed. So lets give it a try now.

joekr · 2023-03-31T23:56:10Z

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main
/test pull-cluster-api-e2e-full-main

killianmuldoon

/retest

furkatgofurov7

Thanks for the PR, few suggestions inline:

Looks like, it is missing a Makefile target update here and a copy of this for v1.4.

test/e2e/config/docker.yaml

docs/release/release-tasks.md

killianmuldoon · 2023-04-03T13:57:30Z

/test pull-cluster-api-e2e-full-main

killianmuldoon · 2023-04-03T14:10:31Z

/test pull-cluster-api-e2e-full-main

test/e2e/config/docker.yaml

killianmuldoon · 2023-04-03T15:06:54Z

/test pull-cluster-api-e2e-full-main

joekr · 2023-04-03T19:10:19Z

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main
/test pull-cluster-api-e2e-full-main

killianmuldoon · 2023-04-03T19:11:07Z

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

k8s-ci-robot · 2023-04-03T19:11:10Z

@killianmuldoon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-ipv6-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-test-mink8s-main
pull-cluster-api-verify-main

In response to this:

/test pull-cluster-api-e2e-workload-upgrade-1-25-latest-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

killianmuldoon · 2023-04-03T19:11:28Z

/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

test/e2e/clusterctl_upgrade_test.go

joekr · 2023-04-04T12:54:28Z

/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main
/test pull-cluster-api-e2e-full-main

killianmuldoon

/lgtm

@fabriziopandini for final approval.

k8s-ci-robot · 2023-04-04T15:52:32Z

LGTM label has been added.

Git tree hash: 5fce735c9667869faef2cd62c41ec7503f368142

test/e2e/config/docker.yaml

furkatgofurov7

Thanks @joekr for working on this!

/lgtm

k8s-ci-robot · 2023-04-04T16:27:36Z

LGTM label has been added.

Git tree hash: 6e98b1fbfe7f1ddc3ec2d9e4f11489f08176bca2

fabriziopandini · 2023-04-04T19:18:21Z

final check
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

fabriziopandini · 2023-04-05T07:48:22Z

@joekr awesome job!
/lgtm
/approve

k8s-ci-robot · 2023-04-05T07:48:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Mar 31, 2023

k8s-ci-robot requested a review from JoelSpeed March 31, 2023 01:22

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2023

k8s-ci-robot requested a review from Jont828 March 31, 2023 01:22

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2023

fabriziopandini reviewed Mar 31, 2023

View reviewed changes

fabriziopandini mentioned this pull request Mar 31, 2023

🌱 Update kind to v0.18.0 #8433

Merged

joekr force-pushed the bump-versions-v1.5 branch from ba5f9e2 to f1492f9 Compare March 31, 2023 14:34

joekr force-pushed the bump-versions-v1.5 branch from f1492f9 to f6b734d Compare March 31, 2023 23:33

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2023

killianmuldoon reviewed Apr 1, 2023

View reviewed changes

furkatgofurov7 reviewed Apr 2, 2023

View reviewed changes

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

joekr force-pushed the bump-versions-v1.5 branch 2 times, most recently from 6a4c36f to 624a7e3 Compare April 3, 2023 13:41

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2023

joekr commented Apr 3, 2023

View reviewed changes

docs/release/release-tasks.md Show resolved Hide resolved

killianmuldoon reviewed Apr 3, 2023

View reviewed changes

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

joekr force-pushed the bump-versions-v1.5 branch from 624a7e3 to 89509bb Compare April 3, 2023 15:05

joekr force-pushed the bump-versions-v1.5 branch from 89509bb to bc18bd4 Compare April 3, 2023 17:51

killianmuldoon reviewed Apr 4, 2023

View reviewed changes

test/e2e/clusterctl_upgrade_test.go Show resolved Hide resolved

joekr force-pushed the bump-versions-v1.5 branch from bc18bd4 to 4a1e3bb Compare April 4, 2023 12:52

killianmuldoon reviewed Apr 4, 2023

View reviewed changes

k8s-ci-robot assigned killianmuldoon Apr 4, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023

furkatgofurov7 suggested changes Apr 4, 2023

View reviewed changes

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved

prepare main branch for v1.5 development

eea6590

joekr force-pushed the bump-versions-v1.5 branch from 4a1e3bb to eea6590 Compare April 4, 2023 16:21

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023

k8s-ci-robot requested a review from killianmuldoon April 4, 2023 16:21

furkatgofurov7 reviewed Apr 4, 2023

View reviewed changes

k8s-ci-robot assigned furkatgofurov7 Apr 4, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023

k8s-ci-robot assigned fabriziopandini Apr 5, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023

k8s-ci-robot merged commit 29794ea into kubernetes-sigs:main Apr 5, 2023

k8s-ci-robot added this to the v1.5 milestone Apr 5, 2023

killianmuldoon mentioned this pull request Apr 24, 2023

🌱 Add runtime extension components to release #8438

Merged

sbueringer mentioned this pull request Apr 24, 2023

🌱 test/e2e: cleanup test files #8557

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 prepare main branch for v1.5 development #8430

🌱 prepare main branch for v1.5 development #8430

joekr commented Mar 31, 2023

joekr commented Mar 31, 2023

fabriziopandini left a comment

killianmuldoon commented Mar 31, 2023 •

edited

Loading

fabriziopandini commented Mar 31, 2023

joekr commented Mar 31, 2023

killianmuldoon commented Mar 31, 2023

joekr commented Mar 31, 2023 •

edited

Loading

joekr commented Mar 31, 2023

killianmuldoon left a comment

furkatgofurov7 left a comment

killianmuldoon commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

joekr commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

k8s-ci-robot commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

joekr commented Apr 4, 2023

killianmuldoon left a comment

k8s-ci-robot commented Apr 4, 2023

furkatgofurov7 left a comment

k8s-ci-robot commented Apr 4, 2023

fabriziopandini commented Apr 4, 2023

fabriziopandini commented Apr 5, 2023

k8s-ci-robot commented Apr 5, 2023

🌱 prepare main branch for v1.5 development #8430

🌱 prepare main branch for v1.5 development #8430

Conversation

joekr commented Mar 31, 2023

joekr commented Mar 31, 2023

fabriziopandini left a comment

Choose a reason for hiding this comment

killianmuldoon commented Mar 31, 2023 • edited Loading

fabriziopandini commented Mar 31, 2023

joekr commented Mar 31, 2023

killianmuldoon commented Mar 31, 2023

joekr commented Mar 31, 2023 • edited Loading

joekr commented Mar 31, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

furkatgofurov7 left a comment

Choose a reason for hiding this comment

killianmuldoon commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

joekr commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

k8s-ci-robot commented Apr 3, 2023

killianmuldoon commented Apr 3, 2023

joekr commented Apr 4, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 4, 2023

furkatgofurov7 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 4, 2023

fabriziopandini commented Apr 4, 2023

fabriziopandini commented Apr 5, 2023

k8s-ci-robot commented Apr 5, 2023

killianmuldoon commented Mar 31, 2023 •

edited

Loading

joekr commented Mar 31, 2023 •

edited

Loading