-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add support or concurrent MD upgrades in classy clusters #8432
✨ add support or concurrent MD upgrades in classy clusters #8432
Conversation
510d8a9
to
bc42715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review focusing on the production code change.
Please also add a bit of PR description describing the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending documentation
a007658
to
9cbf19e
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 420fdd50e7d6befae1eab6f647c10de8967ce62f
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As per Wed 12th office hours discussion /cherry-pick release-1.4 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: new pull request created: #8528 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area clusterclass |
What this PR does / why we need it:
This PR adds support to concurrently upgrade MachineDeployments in Classy Clusters.
The maximum concurrency is defined by setting the
topology.cluster.x-k8s.io/upgrade-concurrency
annotation on the Cluster. If unspecified a default concurrency of 1 is used (only one MachineDeployment is upgraded at a time).Example: If the annotation
"topology.cluster.x-k8s.io/upgrade-concurrency": "3"
is set on the Cluster at most 3 MachineDeployments will be upgraded concurrently.This upgrade concurrency honors the
topology.cluster.x-k8s.io/defer-upgrade
andtopology.cluster.x-k8s.io/hold-upgrade-sequence
annotations applied on the MachineDeploymentTopology and upgrades the qualifying MachineDeployments concurrently.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #