Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump github.com/go-logr/logr from 1.2.3 to 1.2.4 #8461

Merged
merged 2 commits into from
Apr 4, 2023
Merged

🌱 Bump github.com/go-logr/logr from 1.2.3 to 1.2.4 #8461

merged 2 commits into from
Apr 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2023 •
edited

Bumps github.com/go-logr/logr from 1.2.3 to 1.2.4.

Release notes

Sourced from github.com/go-logr/logr's releases.

v1.2.4

This is a collection of small bugfixes and documentation updates.

What's Changed

New Contributors

Full Changelog: go-logr/logr@v1.2.3...v1.2.4

Commits
  • 4da5305 make Discard logger equal to null logger
  • 4d25940 funcr: optimize WithValues/WithName/WithCallDepth
  • 00ed9d0 Merge pull request #163 from thockin/example-v-enabled
  • d4762a8 Merge pull request #161 from thockin/master
  • b10dd33 Merge pull request #162 from thockin/github-assign
  • b818fb2 Add examples for Logger methods
  • 18e8b87 Make github assign PRs and issues
  • 5b49379 Fix comments on optional sink interfaces
  • af0016d Merge pull request #159 from thockin/master
  • 4497483 Merge pull request #160 from thockin/pr-148-takeover
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2023
killianmuldoon
killianmuldoon reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6ae4adbb19cdd32747bb4292ef3abc9839d2d1fe

@killianmuldoon
Copy link
Contributor

/retest

@killianmuldoon
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 4, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@killianmuldoon
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Failed to re-open PR: state cannot be changed. The dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch has been deleted.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch April 4, 2023 10:50
@killianmuldoon killianmuldoon restored the dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch April 4, 2023 10:50
@killianmuldoon
Copy link
Contributor

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot
🌱 Bump github.com/go-logr/logr from 1.2.3 to 1.2.4
e26aa92 
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/go-logr/logr/releases)
- [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md)
- [Commits](go-logr/logr@v1.2.3...v1.2.4)

---
updated-dependencies:
- dependency-name: github.com/go-logr/logr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch from b1454f7 to e26aa92 Compare April 4, 2023 10:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 4, 2023
@killianmuldoon
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 4, 2023
@killianmuldoon killianmuldoon force-pushed the dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch from ba7a073 to dfeaf0e Compare April 4, 2023 10:59
@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16ee45f029d299d64b61d85a12d55eeb0e050d5a

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit f49fa9c into main Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Apr 4, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/go-logr/logr-1.2.4 branch April 4, 2023 14:46
@johannesfrey
Copy link
Contributor

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Jun 16, 2023
@killianmuldoon
Copy link
Contributor

/area dependency

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Jun 16, 2023
@johannesfrey
Copy link
Contributor

/remove-area ci
/area dependency

@k8s-ci-robot k8s-ci-robot removed the area/ci Issues or PRs related to ci label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-ci-robot @killianmuldoon @fabriziopandini @johannesfrey