Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [WIP][DoNotReview] Reproduce issue #8486 #8492

Closed
wants to merge 3 commits into from
Closed

🐛 [WIP][DoNotReview] Reproduce issue #8486 #8492

wants to merge 3 commits into from

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Apr 6, 2023 •
edited
Loading

What this PR does / why we need it:

Trying to reproduce #8486 for further triage.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

/label kind/flake

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) /label kind/flake cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label kind/flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/kind flake

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Apr 6, 2023
@chrischdi chrischdi marked this pull request as draft April 6, 2023 14:26
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

This is the relevant one

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

1 similar comment
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 11, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

4 similar comments
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

2 similar comments
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

1 similar comment
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2023
@chrischdi
Copy link
Member Author

So this seems to allow reproducing the issue. I'll kick off another try to see if it really is and also want to try if its locally reproducible by this.

Failure to analyze: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/8492/pull-cluster-api-e2e-informing-main/1646484712434176000

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

So this seems to allow reproducing the issue. I'll kick off another try to see if it really is and also want to try if its locally reproducible by this.

Failure to analyze: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/8492/pull-cluster-api-e2e-informing-main/1646484712434176000

/test pull-cluster-api-e2e-informing-main

Analizing this failure:

It shows the following condition at the cluster object:

  - lastTransitionTime: "2023-04-13T13:26:32Z"
    message: 'error computing the desired state of the Cluster topology: failed to
      apply patches: failed to generate patches for patch "test-patch": failed to
      call extension handler "generate-patches.k8s-upgrade-with-runtimesdk": failed
      to get extension handler "generate-patches.k8s-upgrade-with-runtimesdk" from
      registry: handler with name "generate-patches.k8s-upgrade-with-runtimesdk" has
      not been registered'
    reason: TopologyReconcileFailed

source

@chrischdi
Copy link
Member Author

reproduced other issue

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

pull-cluster-api-e2e-informing-main d9c4972 link

This did hit a different issue.

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

Reproduced at pull-cluster-api-e2e-informing-main d9c4972 link false

Let's try to catch it again

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 9, 2023
@chrischdi
Copy link
Member Author

Let's see if this fixes things:

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

Hitting the suite timeout is good! :-) This indicates that #8625 would fix that issue.

/test pull-cluster-api-e2e-informing-main

@chrischdi
test/framework fix docker pod log collector
b474354 
When using ExecContainerInput to create the tarball, the same buffer
got used for stdout and stderr. This broke the tarball which resulted
in not extracting the files.
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main b474354 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2023
@chrischdi chrischdi closed this May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrischdi @k8s-ci-robot