Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Remove roadmap.md from the book #8544

Merged
merged 3 commits into from
May 4, 2023
Merged

📖 Remove roadmap.md from the book #8544

merged 3 commits into from
May 4, 2023

Conversation

gantanikhilraj
Copy link
Contributor

Removed link to roadmap discussion from the book and,
Replaced the text :
From,
You can find the Cluster API roadmap discussion at #5556 . Please feel free to participate!
to
The Cluster API roadmap discussion will take place during the weekly office hours.

Fixes #8451

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @gantanikhilraj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gantanikhilraj
Copy link
Contributor Author

gantanikhilraj commented Apr 21, 2023 •
edited
Loading

Hello @killianmuldoon , please check the PR, I think it is fixed now. thanks for your guidance in signing the CLA.

@killianmuldoon
Copy link
Contributor

/ok-to-test

killianmuldoon
killianmuldoon reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/approve

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2023
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2023
vincepri
vincepri reviewed Apr 24, 2023
View reviewed changes
docs/book/src/roadmap.md Outdated
Comment on lines 1 to 3
# Cluster API Roadmap

You can find the Cluster API roadmap discussion at [GitHub](https://github.com/kubernetes-sigs/cluster-api/discussions/5556). Please feel free to participate!
The Cluster API roadmap discussion will take place during the weekly office hours.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just delete this page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sbueringer
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2023
@killianmuldoon
Copy link
Contributor

@gantanikhilraj do you have time to follow up and remove this page + remove the link to this page from the summary?

@gantanikhilraj
Copy link
Contributor Author

@gantanikhilraj do you have time to follow up and remove this page + remove the link to this page from the summary?

Ok @killianmuldoon , I will do it.

@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 4, 2023
@killianmuldoon
Copy link
Contributor

/retitle book Remove roadmap.md from the book

@k8s-ci-robot k8s-ci-robot changed the title 🌱 Removed Link in Roadmap.md and re-phrased the text. book Remove roadmap.md from the book May 4, 2023
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f7bfc69059a86b75d7b99a6dab993b3bf9ba35c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@killianmuldoon killianmuldoon changed the title book Remove roadmap.md from the book 📖 Remove roadmap.md from the book May 4, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1a1cf98 into kubernetes-sigs:main May 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 4, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 4, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #8607

In response to this:

/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri left review comments

@killianmuldoon killianmuldoon killianmuldoon left review comments

@elmiko elmiko Awaiting requested review from elmiko

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Remove link to roadmap discussion from the book
6 participants
@gantanikhilraj @k8s-ci-robot @killianmuldoon @sbueringer @k8s-infra-cherrypick-robot @vincepri