[release-1.3] 🌱 Update controller tools to v0.11.4 #8553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
force-pushed
the
pr-1.3-update-controller-tools
branch
from
a7c4883
to
d4a3805
Compare
sbueringer
reviewed
Apr 24, 2023
hack/tools/go.mod
Outdated
| sigs.k8s.io/cluster-api v0.0.0-00010101000000-000000000000 | ||
| sigs.k8s.io/cluster-api/test v0.0.0-00010101000000-000000000000 | ||
| sigs.k8s.io/controller-runtime v0.13.1 | ||
| sigs.k8s.io/controller-tools v0.10.0 | ||
| sigs.k8s.io/controller-tools v0.11.4 |
There was a problem hiding this comment.
I would suggest to keep this version the same to avoid bumping k8s.io to 0.26
killianmuldoon
force-pushed
the
pr-1.3-update-controller-tools
branch
from
d4a3805
to
3c1fd76
Compare
k8s-ci-robot
added
size/S
killianmuldoon
force-pushed
the
pr-1.3-update-controller-tools
branch
from
3c1fd76
to
8a7d23d
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-1.3-update-controller-tools
branch
from
8a7d23d
to
73699ad
Compare
|
Thx! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 202be9714894550a1dfb4f1113910a3f6d655c35
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump controller gen and regenerate based on the new version.
Release notes: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.11.4
Note: This was cherry-picked to enable usage of Kustomize v5 on this branch. See #8546 for more details.
Manual cherry-pick of #8546