-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add flags for configuring rate limits #8579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast review @killianmuldoon !
Tuning these values fixed the issue for me. |
610431b
to
88a9bc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits, but otherwise this looks good. Thanks for opening this PR!
88a9bc9
to
97f19cf
Compare
All the controllers have built-in rate limits. They throttle themselves if they hit this limit. So far it has not been possible to configure these limits. This commit adds flags to the controllers for setting both the QPS and the burst for the rate limits. The default remains the same as before (20 QPS, 30 burst). New flags (for each controller, including CAPD): --kube-api-qps --kube-api-burst Also adds .devcontainer to .gitignore.
97f19cf
to
ba34136
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: a5f86648aaaa9b052f6a1db2c7df050697b28747
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/core provider/control-plane-kubeadm provider/infrastructure-docker |
What this PR does / why we need it:
All the controllers have built-in rate limits. They throttle themselves if they hit this limit. So far it has not been possible to configure these limits. This commit adds flags to the controllers for setting both the QPS and the burst for the rate limits. The default remains the same as before (20 QPS, 30 burst).
New flags (for each controller, including CAPD):
--kube-api-qps
--kube-api-burst
Also adds .devcontainer to .gitignore.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8052