✨ Add flags for configuring rate limits #8579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Thanks for the fast review @killianmuldoon ! Tuning these values fixed the issue for me. |
lentzi90
force-pushed
the
lentzi90/rate-limits
branch
from
610431b
to
88a9bc9
Compare
lentzi90
force-pushed
the
lentzi90/rate-limits
branch
from
88a9bc9
to
97f19cf
Compare
sbueringer
reviewed
Apr 28, 2023
sbueringer
reviewed
Apr 28, 2023
All the controllers have built-in rate limits. They throttle themselves if they hit this limit. So far it has not been possible to configure these limits. This commit adds flags to the controllers for setting both the QPS and the burst for the rate limits. The default remains the same as before (20 QPS, 30 burst). New flags (for each controller, including CAPD): --kube-api-qps --kube-api-burst Also adds .devcontainer to .gitignore.
lentzi90
force-pushed
the
lentzi90/rate-limits
branch
from
97f19cf
to
ba34136
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: a5f86648aaaa9b052f6a1db2c7df050697b28747
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/area provider/core provider/control-plane-kubeadm provider/infrastructure-docker |
k8s-ci-robot
added
area/provider/core
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
All the controllers have built-in rate limits. They throttle themselves if they hit this limit. So far it has not been possible to configure these limits. This commit adds flags to the controllers for setting both the QPS and the burst for the rate limits. The default remains the same as before (20 QPS, 30 burst).
New flags (for each controller, including CAPD):
--kube-api-qps
--kube-api-burst
Also adds .devcontainer to .gitignore.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #8052