-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Return error on infra cluster and control plane discovery #8604
🐛 Return error on infra cluster and control plane discovery #8604
Conversation
719ca46
to
fabd2f4
Compare
fabd2f4
to
14c022b
Compare
If no control plane reference is set in the Cluster object the describe cluster command will fail. We should validate the error in any case. Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
14c022b
to
f928305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 4498cacec88468e5c1a39fcc20d293b9e0ea7314
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykakarap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Probably worth back-porting this fix into the supported release branches? |
/hold cancel |
/cherry-pick release-1.4 |
/cherry-pick release-1.3 |
@killianmuldoon: new pull request created: #8609 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8610 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If no control plane reference is set in the Cluster object the describe cluster command will fail. We should validate the error in any case.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8603
Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum