🐛 MachinePool: always patch owned conditions, fix GetTypedPhase, doc fixes #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sbueringer
commented
May 9, 2023
| @@ -157,18 +157,16 @@ func (r *MachinePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
|
|
|||
| // Always attempt to patch the object and status after each reconciliation. | |||
| // Patch ObservedGeneration only if the reconciliation completed successfully | |||
| patchOpts := []patch.Option{} | |||
| patchOpts := []patch.Option{ | |||
There was a problem hiding this comment.
We should always patch owned conditions. Only observedGeneration should only be patched if we didn't get an error.
|
/assign @CecileRobertMichon @fabriziopandini |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 70c4309b0906376f74766bd83660d0e207fb5af1
|
|
/assign @fabriziopandini |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/area machinepool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
While taking a closer look at MachinePools, I found a few smaller issues.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #