-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 MachinePool: always patch owned conditions, fix GetTypedPhase, doc fixes #8627
🐛 MachinePool: always patch owned conditions, fix GetTypedPhase, doc fixes #8627
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
@@ -157,18 +157,16 @@ func (r *MachinePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
|
|||
// Always attempt to patch the object and status after each reconciliation. | |||
// Patch ObservedGeneration only if the reconciliation completed successfully | |||
patchOpts := []patch.Option{} | |||
patchOpts := []patch.Option{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should always patch owned conditions. Only observedGeneration should only be patched if we didn't get an error.
/assign @CecileRobertMichon @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM label has been added. Git tree hash: 70c4309b0906376f74766bd83660d0e207fb5af1
|
/assign @fabriziopandini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area machinepool |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
While taking a closer look at MachinePools, I found a few smaller issues.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #