-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] 🐛 test/e2e check for machines being ready after provisioning on Runtime SDK test #8647
[release-1.3] 🐛 test/e2e check for machines being ready after provisioning on Runtime SDK test #8647
Conversation
… SDK test The topology controller checks if the ControlPlane IsScaling() or any MachineDeployment IsRollingOut() before running the BeforeClusterUpgrade hook. In some cases in e2e tests the nodes were not ready yet and the timeout for the BeforeClusterUpgrade hook was not sufficient for the nodes to get ready and running the hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: f75ec1ded88ed24edc0f939c94fecfdf33dc040d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area testing |
/area e2e-testing |
/area e2e-testing |
This is an automated cherry-pick of #8625
/assign chrischdi