Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.4] 🐛 Delegate CAPD port selection to the container runtime #8655

Merged
merged 1 commit into from
May 12, 2023
Merged

[release-1.4] 🐛 Delegate CAPD port selection to the container runtime #8655

merged 1 commit into from
May 12, 2023

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #8642

/assign killianmuldoon

@killianmuldoon
Delegate CAPD port selection to the container runtime
3491918 
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 12, 2023
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone May 12, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2023
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-4
  • /test pull-cluster-api-e2e-release-1-4
  • /test pull-cluster-api-test-mink8s-release-1-4
  • /test pull-cluster-api-test-release-1-4
  • /test pull-cluster-api-verify-release-1-4

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-4
  • /test pull-cluster-api-e2e-full-release-1-4
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-4
  • /test pull-cluster-api-e2e-informing-release-1-4
  • /test pull-cluster-api-e2e-scale-release-1-4-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-release-1-4

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-4
  • pull-cluster-api-build-release-1-4
  • pull-cluster-api-e2e-informing-ipv6-release-1-4
  • pull-cluster-api-e2e-informing-release-1-4
  • pull-cluster-api-e2e-release-1-4
  • pull-cluster-api-test-mink8s-release-1-4
  • pull-cluster-api-test-release-1-4
  • pull-cluster-api-verify-release-1-4

In response to this:

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eceac82657a42686dd952194dc33d423a5e7c258

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 59fb779 into kubernetes-sigs:release-1.4 May 12, 2023
@johannesfrey
Copy link
Contributor

/area provider/infrastructure-docker

@k8s-ci-robot k8s-ci-robot added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @johannesfrey @killianmuldoon