-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 upgrading control plane should only be blocked if MD are upgrading (not just rolling out) #8658
🌱 upgrading control plane should only be blocked if MD are upgrading (not just rolling out) #8658
Conversation
@ykakarap: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thank you very much! /lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: 3efaa467661d399d521b02081641efdb33a58f9e
|
This PR makes our code simpler and more consistent, nice work! /lgtm |
cfe525b
to
80576b0
Compare
Squashed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area clusterclass |
What this PR does / why we need it:
This PR relaxes the conditions under which for managed topologies ControlPlane upgrade should be blocked.
ControlPlane upgrade should be blocked if the MachineDeployments are upgrading, other actions like scale up, scale down, MHC etc of MDs should not block control plane upgrade.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #