🐛 Remove non-functioning ginkgo.no-color flag #8703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/hold Want to fix up another issue. |
k8s-ci-robot
added
the
do-not-merge/hold
killianmuldoon
force-pushed
the
pr-revert-cgroups
branch
from
8fc1fae
to
004e559
Compare
k8s-ci-robot
added
size/XS
killianmuldoon
changed the title
|
/test ? |
|
@killianmuldoon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-dualstack-ipv6-main |
sbueringer
reviewed
May 19, 2023
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-revert-cgroups
branch
from
004e559
to
f507fa5
Compare
k8s-ci-robot
added
size/S
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/hold
killianmuldoon
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e110010bc60372ab2fbe6d8afe92870ba6d4863f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/area e2e-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ginkgo.no-colorflag which is not supported in earlier versions of the conformance tests. This flag was not functioning correctly even when enabled.Currently causing failures in: