-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 handle nil pointer in clusterctl describe #8724
🐛 handle nil pointer in clusterctl describe #8724
Conversation
Hi @bavarianbidi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Second time I've seen this flake where the env cleanup fails 🤔 |
f2eec62
to
c79417b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nil check makes sense.
I will do another pass and will take a closer look at the updated tests.
Thank you. In the end, i just copied the |
c79417b
to
bf173ab
Compare
bf173ab
to
ba83907
Compare
ba83907
to
8236791
Compare
8236791
to
946db30
Compare
if a cluster as an empy bootstrap.configref in the machinedeployment (which is allowed), a nil pointer will raise if clusterctl describe cluster is called with --show-templates. Also add a second type of a fake machinedeployment which has a secret reference in the boostrap object instead of a config ref Signed-off-by: Mario Constanti <mario@constanti.de>
946db30
to
5adeb34
Compare
LGTM label has been added. Git tree hash: 31658f380bfe7f2f907d573d5b300afc2ed5e99e
|
Thank you very much. Very nice test coverage!! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
if a cluster as an empy bootstrap.configref in the machinedeployment (which is allowed), a nil pointer will raise if clusterctl describe cluster is called with --show-templates.
Also add a second type of a fake machinedeployment which has a secret reference in the boostrap object instead of a config ref
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #