-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Pin delve to version supporting go 1.19 #8726
🌱 Pin delve to version supporting go 1.19 #8726
Conversation
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't find a release note reference for the versioning change - but https://twitter.com/DelveDebug/status/1600924650812252160?cxt=HHwWgIClvZyf0LcsAAAA
Thx! /lgtm |
LGTM label has been added. Git tree hash: 3a48c966fddebdc515b695567d3dd1c84842ad1d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@killianmuldoon: new pull request created: #8727 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pin delve to a release that supports Go 1.19.
Note: After the 1.9.1 release delve changed to a release scheme matching the Go version.
/area devtools