-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use ClusterCacheTracker consistently (instead of NewClusterClient) #8744
🌱 Use ClusterCacheTracker consistently (instead of NewClusterClient) #8744
Conversation
/test pull-cluster-api-e2e-full-main |
f6b1b07
to
b42793e
Compare
This PR is ready for review but I want to hold merging it so we can easily do a before/after comparison with the goofy provider. /assign @fabriziopandini @killianmuldoon @ykakarap |
/test pull-cluster-api-e2e-full-main |
Signed-off-by: Stefan Büringer buringerst@vmware.com
b42793e
to
051b006
Compare
Nice cleanup! |
LGTM label has been added. Git tree hash: be91c8c1cf48f2a8c1962e10efd29fdb1aa11772
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area clustercachetracker
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
We still had a few places left where we created clients for the workload cluster via
NewClusterClient
instead of using ClusterCacheTracker. This PR replaces the last usages ofNewClusterClient
.I expect that it's more efficent to use a cached client vs re-creating it all the time
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #