-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ hack/observability: Add Parca, Bump observability tools, Add Grafana scale dashboard #8754
✨ hack/observability: Add Parca, Bump observability tools, Add Grafana scale dashboard #8754
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grat job in updating all the charts and kudos for kicking of the work about creating grafana dashboard for our test environment
Q: Might be I'm wrong, but I don't see the part installing Parca
11703b0
to
d6537c6
Compare
Thx good catch. Forgot to push the last commit :/. Should be there now |
if deployment.Spec.Template.Annotations == nil { | ||
deployment.Spec.Template.Annotations = map[string]string{} | ||
} | ||
deployment.Spec.Template.Annotations["parca.dev/port"] = "6060" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be
deployment.Spec.Template.Annotations["parca.dev/port"] = "6060" | |
deployment.Spec.Template.Annotations["parca.dev/port"] = d.ProfilerPort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. This should point to the port in the container which is always 6060 (see l. 832)
ProfilerPort is the one outside of kind on your local machine
/retest |
/lgtm |
LGTM label has been added. Git tree hash: e8a9edaaded990bc31e5744019865761f04f12ae
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area devtools |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #