Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ hack/observability: Add Parca, Bump observability tools, Add Grafana scale dashboard #8754

Merged
merged 1 commit into from
May 31, 2023
Merged

✨ hack/observability: Add Parca, Bump observability tools, Add Grafana scale dashboard #8754

merged 1 commit into from
May 31, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
hack/observability: Add Parca, Add Grafana dashboard for scale testing
d6537c6 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2023
@sbueringer sbueringer changed the title ✨ hack/observability: Add Parca, Add Grafana dashboard for scale testing ✨ hack/observability: Add Parca, Bump observability tools, Add Grafana scale dashboard May 26, 2023
fabriziopandini
fabriziopandini reviewed May 27, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grat job in updating all the charts and kudos for kicking of the work about creating grafana dashboard for our test environment

Q: Might be I'm wrong, but I don't see the part installing Parca

hack/observability/grafana/kustomization.yaml Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

Q: Might be I'm wrong, but I don't see the part installing Parca

Thx good catch. Forgot to push the last commit :/. Should be there now

fabriziopandini
fabriziopandini reviewed May 30, 2023
View reviewed changes
hack/tools/tilt-prepare/main.go
if deployment.Spec.Template.Annotations == nil {
deployment.Spec.Template.Annotations = map[string]string{}
}
deployment.Spec.Template.Annotations["parca.dev/port"] = "6060"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be

Suggested change
deployment.Spec.Template.Annotations["parca.dev/port"] = "6060"
deployment.Spec.Template.Annotations["parca.dev/port"] = d.ProfilerPort

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. This should point to the port in the container which is always 6060 (see l. 832)

ProfilerPort is the one outside of kind on your local machine

@sbueringer
Copy link
Member Author

/retest

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8a9edaaded990bc31e5744019865761f04f12ae

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 89429b8 into kubernetes-sigs:main May 31, 2023
10 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 31, 2023
@sbueringer sbueringer deleted the pr-scale-dashboard branch May 31, 2023 13:01
@johannesfrey
Copy link
Contributor

/area devtools

@k8s-ci-robot k8s-ci-robot added the area/devtools Issues or PRs related to devtools label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbueringer @fabriziopandini @k8s-ci-robot @johannesfrey