Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update Runtime Extension CAPI Book #8760

Merged
merged 1 commit into from
Jun 5, 2023
Merged

📖 Update Runtime Extension CAPI Book #8760

merged 1 commit into from
Jun 5, 2023

Conversation

aniruddha2000
Copy link
Contributor

  • Add Point for registering the app
  • Add an ExtensionConfig Example

What this PR does / why we need it:
This PR enhances the CAPI Book in the Runtime Extension Section.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8679

/cc @killianmuldoon

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 27, 2023
killianmuldoon
killianmuldoon reviewed May 27, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for taking this on!

Could you add a section above Settings, called ExtensionConfig, and add the example and some text explaining what it does, how it works, and how to check status to ensure it's discovered.

docs/book/src/tasks/experimental-features/runtime-sdk/implement-extensions.md Outdated Show resolved Hide resolved
fabriziopandini
fabriziopandini reviewed May 29, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this

docs/book/src/tasks/experimental-features/runtime-sdk/implement-extensions.md Outdated Show resolved Hide resolved
docs/book/src/tasks/experimental-features/runtime-sdk/implement-extensions.md Outdated Show resolved Hide resolved
@aniruddha2000
Update Runtime Extension CAPI Book
a0100a7 
- Add Point for registering the app
- Add an ExtensionConfig Example

Signed-off-by: Aniruddha Basak <codewithaniruddha@gmail.com>
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8492b3644d308a329f51737dc353f627b6ef9ad

@sbueringer
Copy link
Member

Thx!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@killianmuldoon
Copy link
Contributor

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 60b1426 into kubernetes-sigs:main Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

📖 add runtime ExtensionConfig in the CAPI book
5 participants
@aniruddha2000 @fabriziopandini @k8s-ci-robot @sbueringer @killianmuldoon