🐛 fix fail-swap-on=false flag not being part of kind images anymore #8767

chrischdi · 2023-05-30T18:14:13Z

What this PR does / why we need it:

This PR adds a json patch for KubeadmControlPlanes and MachineDeployments, to set the fail-swap-on flag for the kubelet to false in our ClusterClasses for the release, main and v1.4 tests.

This prevents that the kubelet refuses to start for newer kind images which don't specify the flag anymore (because kind sets the configuration parameter in KubeletConfiguration.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8766

chrischdi · 2023-05-30T18:14:18Z

/test help

k8s-ci-robot · 2023-05-30T18:14:19Z

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-dualstack-ipv6-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-ipv6-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-ipv6-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-test-mink8s-main
pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-05-30T18:14:39Z

/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

chrischdi · 2023-05-30T18:16:23Z

Ah damn, test-infra issue ongoing 🤦

sbueringer · 2023-05-30T18:47:54Z

/lgtm

Assuming CI is green once Prow is not overloaded anymore

k8s-ci-robot · 2023-05-30T18:48:00Z

LGTM label has been added.

Git tree hash: f699b1c54d14e8372e72941c4fe6f2b3af6257a6

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start-runtimesdk.yaml

killianmuldoon

Should this be added in the template for the machinePools as well? Seems like those would fail at 1.27+

Otherwise looks good to me.

chrischdi · 2023-05-30T19:57:17Z

/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

chrischdi · 2023-05-30T21:24:28Z

/test pull-cluster-api-e2e-full-main
/test

k8s-ci-robot · 2023-05-30T21:24:30Z

@chrischdi: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-dualstack-ipv6-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-ipv6-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
/test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test pull-cluster-api-e2e-full-main
/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-05-30T21:24:47Z

/test pull-cluster-api-e2e-informing-main

sbueringer · 2023-05-31T08:29:37Z

Q: We technically have the same issue for v0.4-v1.3 right? We didn't fix it yet as those those tests are not run locally that frequently (?) and it only fails if someone has a Machine where swap is enabled?

Would it make sense to just set it on all versions? If possible I would like to avoid running into this issue again.

chrischdi · 2023-05-31T10:29:23Z

We don't have it in ci, because there is no swap enabled there.

For <= v1.3, it depends on the used versions of the kind images (dunno if there will be a released kind node image < v1.27 which faces the same issue, also v1.27 is not supported in v1.3).

sbueringer · 2023-05-31T10:42:35Z

The change in kind was only done to images for Kubernetes >= 1.27 right? They didn't change the older Kubenetes versions? (just because they are always pushing all versions: https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0)

chrischdi · 2023-05-31T12:53:42Z

The change in kind was only done to images for Kubernetes >= 1.27 right? They didn't change the older Kubenetes versions? (just because they are always pushing all versions: https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0)

This needs to get researched (but looks like that).

sbueringer · 2023-05-31T13:16:50Z

Would be good to know before we merge ideally

sbueringer · 2023-05-31T13:32:38Z

Just talked to Killian, what do you think about just setting the swap setting everywhere? Shouldn't hurt and we don't have to do more research.

chrischdi · 2023-06-01T06:17:54Z

/test help

k8s-ci-robot · 2023-06-01T06:17:56Z

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-test-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-dualstack-ipv6-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-ipv6-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp
/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
/test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-informing-main
pull-cluster-api-e2e-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chrischdi · 2023-06-01T06:18:06Z

/test pull-cluster-api-apidiff-main
/test pull-cluster-api-e2e-full-dualstack-ipv6-main
/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-main
/test pull-cluster-api-e2e-ipv6-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-scale-main-experimental
/test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
/test pull-cluster-api-test-mink8s-main

chrischdi · 2023-06-01T06:24:53Z

/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-scale-main-experimental

k8s-ci-robot · 2023-06-01T06:29:51Z

@chrischdi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp	`ea267b8`	link	false	`/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp`
pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp	`ea267b8`	link	false	`/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp`
pull-cluster-api-e2e-scale-main-experimental	`c939389`	link	false	`/test pull-cluster-api-e2e-scale-main-experimental`
pull-cluster-api-e2e-mink8s-main	`c939389`	link	false	`/test pull-cluster-api-e2e-mink8s-main`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sbueringer · 2023-06-01T06:51:16Z

@killianmuldoon looks like we have an issue in mink8s. I think we have to clone k/k for this job as well so we can build the node image if necessary

sbueringer · 2023-06-01T06:53:28Z

Or maybe we should better pin to a 1.24 version we have a kind image for. I think we don't have to use latest 1.24 and it makes the job quicker

killianmuldoon · 2023-06-01T08:14:12Z

The way to do this is to set extra_refs in the prow job yaml, right? To bring the presubmit to parity with the periodic job if I understand right.

I think it might be better to let this job build instead of trying to constantly keep track of which version we should be using in the job.

killianmuldoon · 2023-06-01T08:15:06Z

But because this is specifically a minimum lower bound I'd also be happy to pin it to something like 1.24.2 and just never bump it without reason until we officially bump our mininimum supported K8s version

sbueringer · 2023-06-01T08:21:40Z

Talked to Killian. We would pin to v1.24.13. Overall it shouldn't matter too much, but with the highest available patch version we have probably better compatibility with the kind version we use and Kubernetes has more bugfixes :).

There is not a big benefit to build 1.24 latest as the goal is to roughly test against "min". It would also just take more time and resources to always build.

sbueringer · 2023-06-01T08:29:10Z

Thx!

/lgtm
/approve

k8s-ci-robot · 2023-06-01T08:29:14Z

LGTM label has been added.

Git tree hash: 8fc4ba71427a55f530303262b4602e475ce6f97c

k8s-ci-robot · 2023-06-01T08:29:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chrischdi · 2023-06-01T08:39:46Z

@sbueringer : something worth cherry-picking? I think so!

killianmuldoon

@sbueringer : something worth cherry-picking? I think so!

Probably needs to be done manually - let's see 😄

killianmuldoon · 2023-06-01T08:49:44Z

/cherry-pick release-1.4

k8s-infra-cherrypick-robot · 2023-06-01T08:50:20Z

@killianmuldoon: #8767 failed to apply on top of branch "release-1.4":

Applying: test/e2e fix fail-swap-on=false flag not being part of kind images anymore
Using index info to reconstruct a base tree...
M	test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml
A	test/e2e/data/infrastructure-docker/v1.4/bases/cluster-with-kcp.yaml
A	test/e2e/data/infrastructure-docker/v1.4/bases/md.yaml
A	test/e2e/data/infrastructure-docker/v1.4/bases/mp.yaml
A	test/e2e/data/infrastructure-docker/v1.4/clusterclass-quick-start.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): test/e2e/data/infrastructure-docker/v1.4/bases/mp.yaml deleted in HEAD and modified in test/e2e fix fail-swap-on=false flag not being part of kind images anymore. Version test/e2e fix fail-swap-on=false flag not being part of kind images anymore of test/e2e/data/infrastructure-docker/v1.4/bases/mp.yaml left in tree.
Auto-merging test/e2e/data/infrastructure-docker/v1.2/clusterclass-quick-start.yaml
CONFLICT (content): Merge conflict in test/e2e/data/infrastructure-docker/v1.2/clusterclass-quick-start.yaml
Auto-merging test/e2e/data/infrastructure-docker/v1.2/bases/md.yaml
Auto-merging test/e2e/data/infrastructure-docker/v1.2/bases/cluster-with-kcp.yaml
Auto-merging test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test/e2e fix fail-swap-on=false flag not being part of kind images anymore
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sbueringer · 2023-06-01T09:28:46Z

Fine for me!

chrischdi · 2023-06-01T10:59:19Z

/area provider/infrastructure-docker

chrischdi · 2023-06-01T10:59:55Z

/retitle 🐛 fix fail-swap-on=false flag not being part of kind images anymore

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2023

k8s-ci-robot requested review from jackfrancis and stmcginnis May 30, 2023 18:14

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2023

k8s-ci-robot assigned sbueringer May 30, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023

killianmuldoon reviewed May 30, 2023

View reviewed changes

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start-runtimesdk.yaml Outdated Show resolved Hide resolved

killianmuldoon reviewed May 30, 2023

View reviewed changes

chrischdi force-pushed the pr-fail-swap-on-false branch from c69395a to a651aed Compare May 30, 2023 19:53

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023

k8s-ci-robot requested a review from sbueringer May 30, 2023 19:53

chrischdi force-pushed the pr-fail-swap-on-false branch from a651aed to faf1cb6 Compare May 30, 2023 19:57

chrischdi force-pushed the pr-fail-swap-on-false branch from faf1cb6 to 639e201 Compare May 31, 2023 14:29

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2023

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023

k8s-ci-robot merged commit 9be885c into kubernetes-sigs:main Jun 1, 2023
10 checks passed

k8s-ci-robot added this to the v1.5 milestone Jun 1, 2023

killianmuldoon reviewed Jun 1, 2023

View reviewed changes

chrischdi mentioned this pull request Jun 1, 2023

[release-1.4] 🐛 fix fail-swap-on=false flag not being part of kind images anymore #8777

Merged

k8s-ci-robot added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Jun 1, 2023

k8s-ci-robot changed the title ~~🐛 test/e2e fix fail-swap-on=false flag not being part of kind images anymore~~ 🐛 fix fail-swap-on=false flag not being part of kind images anymore Jun 1, 2023

chrischdi deleted the pr-fail-swap-on-false branch June 1, 2023 12:54

🐛 fix fail-swap-on=false flag not being part of kind images anymore #8767

🐛 fix fail-swap-on=false flag not being part of kind images anymore #8767

Conversation

chrischdi commented May 30, 2023

chrischdi commented May 30, 2023

k8s-ci-robot commented May 30, 2023

chrischdi commented May 30, 2023

chrischdi commented May 30, 2023

sbueringer commented May 30, 2023

k8s-ci-robot commented May 30, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

chrischdi commented May 30, 2023

chrischdi commented May 30, 2023

k8s-ci-robot commented May 30, 2023

chrischdi commented May 30, 2023

sbueringer commented May 31, 2023 • edited Loading

chrischdi commented May 31, 2023 • edited Loading

sbueringer commented May 31, 2023

chrischdi commented May 31, 2023 • edited Loading

sbueringer commented May 31, 2023

sbueringer commented May 31, 2023

chrischdi commented Jun 1, 2023

k8s-ci-robot commented Jun 1, 2023

chrischdi commented Jun 1, 2023

chrischdi commented Jun 1, 2023

k8s-ci-robot commented Jun 1, 2023

sbueringer commented Jun 1, 2023

sbueringer commented Jun 1, 2023

killianmuldoon commented Jun 1, 2023

killianmuldoon commented Jun 1, 2023

sbueringer commented Jun 1, 2023 • edited Loading

sbueringer commented Jun 1, 2023

k8s-ci-robot commented Jun 1, 2023

k8s-ci-robot commented Jun 1, 2023

chrischdi commented Jun 1, 2023

killianmuldoon left a comment

Choose a reason for hiding this comment

killianmuldoon commented Jun 1, 2023

k8s-infra-cherrypick-robot commented Jun 1, 2023

sbueringer commented Jun 1, 2023

chrischdi commented Jun 1, 2023

chrischdi commented Jun 1, 2023

sbueringer commented May 31, 2023 •

edited

Loading

chrischdi commented May 31, 2023 •

edited

Loading

chrischdi commented May 31, 2023 •

edited

Loading

sbueringer commented Jun 1, 2023 •

edited

Loading