-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add in memory provider #8799
✨ Add in memory provider #8799
Conversation
cc @sbueringer |
Link checker issue is fine as it's just a link to a folder introduced in this PR. |
@@ -0,0 +1 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are publishing this file on our release. let's have a follow-up to add an actual working cluster-template here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should do some sort of alpha release to verify this all works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are publishing this file on our release. let's have a follow-up to add an actual working cluster-template here
Probably makes sense to wait with CC support before we do this (or do it as part of implementing CC support)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the template I'm using for experimenting with the new provider.
I will open a follow-up issue to improve it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @ykakarap can update it when he's working on the ClusterClass support (with a template using a CC)
/lgtm /hold Really really great work!!! |
LGTM label has been added. Git tree hash: fb4a5e5a640d7cf4da10141df358d3490317b73b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5fa0113
to
6d9349a
Compare
/hold cancel |
Merging manually to skip over the link checker |
Note:
|
What this PR does / why we need it:
Add the in-memory provider to be used for stress testing
NOTE: The code in this PR has been available for feedback at https://github.com/fabriziopandini/cluster-api-provider-goofy for some time now (and this link has been shared during the latest two office hours).