-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 ClusterCacheTracker: improve error when workload cluster is not reachable #8801
🌱 ClusterCacheTracker: improve error when workload cluster is not reachable #8801
Conversation
5a15402
to
190bd88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 98eb21c4d0a5c817e03cc25ca776362cab2f8783
|
Ups. Shouldn't have used the Cluster CRD with wl clusters :D |
reachable Signed-off-by: Stefan Büringer buringerst@vmware.com
190bd88
to
119bf15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better now!
/lgtm
/approve
LGTM label has been added. Git tree hash: 24e398b48a587b01bce18ba9606db856d2cab709
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
This improves the error when a workload cluster is not reachable.
Before
After
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #