-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add ClusterClass support for in-memory provider #8807
🌱 add ClusterClass support for in-memory provider #8807
Conversation
test/infrastructure/inmemory/templates/clusterclass-in-memory.yaml
Outdated
Show resolved
Hide resolved
c7d8363
to
d16c724
Compare
d16c724
to
1cc6ac4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending last comment
1cc6ac4
to
87c4ee6
Compare
Addressed the last comment. |
/retest |
/lgtm |
LGTM label has been added. Git tree hash: d0927d93f317658524f69f0c55314f39273901af
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/infrastructure-in-memory |
What this PR does / why we need it:
This PR adds ClusterClass support to the
in-memory
provider. It also adds clusterclass and cluster templates for this provider.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #