🐛 fix cluster deletion in the in-memory API server #8818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/hold Adding some cleanup in reconcileDelete functions |
k8s-ci-robot
added
the
do-not-merge/hold
fabriziopandini
force-pushed
the
fix-delete-inmemory-provider
branch
from
a8e34c0
to
ff73bab
Compare
k8s-ci-robot
added
size/L
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@killianmuldoon PTAL |
fabriziopandini
force-pushed
the
fix-delete-inmemory-provider
branch
from
ff73bab
to
fa1cd34
Compare
|
/retest |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 68fa487a2e3d536df9c64520dd1dad8edfddba83
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/area provider/infrastructure-in-memory |
k8s-ci-robot
added
the
area/provider/infrastructure-in-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the cluster deletion to work when using the in-memory API server; the issue was caused by the node drainer using application/json to delete pods (while the controller runtime client uses protobuf)
Rif #8814