-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add startup timeout to the in memory provider #8831
🌱 Add startup timeout to the in memory provider #8831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed everything except unit tests. will do that now
test/infrastructure/inmemory/api/v1alpha1/inmemorymachine_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/api/v1alpha1/inmemorymachine_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/api/v1alpha1/inmemorymachine_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/api/v1alpha1/inmemorymachine_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/api/v1alpha1/inmemorymachine_types.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller_test.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller_test.go
Show resolved
Hide resolved
Changes look good so far |
a79d5bc
to
807b6bd
Compare
807b6bd
to
cbf3a9a
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: f4aed91a78fe9d2d042284ea7d13919ec8ee686e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/infrastructure-in-memory |
What this PR does / why we need it:
Now the in memory provider can fake startup duration for VM, node, etcd and API server; this will make stress test more realistic simulating infrastructure with different performances
Rif #8814