🌱 Deprecate DefaultIndex usage and remove where not needed #8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
commented
Jun 14, 2023
| // | ||
| // Deprecated: This variable is deprecated and will be removed in a future release of Cluster API. | ||
| // Instead please use `[]Index{NodeProviderIDIndex}`. | ||
| var DefaultIndexes = []Index{NodeProviderIDIndex} |
There was a problem hiding this comment.
Decided to deprecate this as I think that the naming is possibly one reason it showed up so many places - possibly confused with index.AddDefaultIndexes. As there's only one index here I think it's fine to just explicitly define the array.
|
/area clustercachetracker |
k8s-ci-robot
added
the
area/clustercachetracker
killianmuldoon
force-pushed
the
pr-remove-default-index
branch
from
2c6401f
to
22b6026
Compare
Signed-off-by: killianmuldoon <kmuldoon@vmware.com>
killianmuldoon
force-pushed
the
pr-remove-default-index
branch
from
22b6026
to
2f8bc8d
Compare
|
Thank you. Nice fix! :) /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 9d1b343df809de62b838c4fc19c6805e7bebdaf6
|
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
remote.DefaultIndexdue to confusing naming and replace its current valid usages with[]Index{NodeProviderIDIndex}instead.Remove the use of the index entirely from places where it is not currently used: